-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[netflow]: disable event normalisation #40635
[netflow]: disable event normalisation #40635
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
776c792
to
a5637f7
Compare
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request is now in conflicts. Could you fix it? 🙏
|
8114154
to
ca5b199
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed commit message
This PR introduces the following:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
N/A
Author's Checklist
N/A
How to test this PR locally
Related issues
Use cases
N/A
Screenshots
CPU profile with event normalisation enabled:
CPU profile with event normalisation disabled:
As you can see between the two screenshots the "GenericEventConverter" and the respective CPU time are completely gone (~13sec) and instead we have a netflow specific net.IP normalisation beat event function that takes (~2.5sec)
Logs
N/A