-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the missing process.name field to System module, Syslog fileset #41354
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
@@ -36,6 +37,7 @@ | |||
"log.syslog.facility.code": 0, | |||
"log.syslog.priority": 6, | |||
"message": "Console: switching to colour frame buffer device 160x50", | |||
"process.name": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems most of the examples I got don't have a process.name
available 🤦♂️ . The tests can be improved on a later PR.
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This PR adds the missing process.name field to System module, Syslog fileset (cherry picked from commit d2796da)
This PR adds the missing process.name field to System module, Syslog fileset (cherry picked from commit d2796da)
Shouldn't we have additional testing to ensure we won't break it in the future? |
We technically have those tests in place already, when the tests run on CI they ingest some files and compare the final event with a golden file, if fields are different, the test fails. The problem is that when we add a new source for the test, we don't have a reference, so they're generated. You can see the One type of test that do not have and would be nice to have is to have a test dataset that can populate all visualisations from the dashboards and ensure that when ingested, the dashboard is correctly populated. That's not as simple to implement but it would be nice to have. |
Proposed commit message
This PR adds the missing
process.name
field to System module, Syslog filesetChecklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
filebeat/modules.d/system.yml
to enable the syslog fileset and ensure Journald input will be usedfilebeat.yml
with your ES and Kibana credentialsprocess.name
and the [Filebeat System] Syslog dashboard ECS contains data. You might have to adjust the time windowRelated issues
## Use cases## Screenshots## Logs