Close handle on signalEvent #9838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
I got the CLA, any latency? |
|
jenkins, test this |
|
@andrewkroh Could you take a look? |
|
@wenhaochen Could you please rebase this on master to pull in some fixes that will make the CI testing start working on this PR. Assuming the tests continue to pass then this LGTM. Thanks. |
wenhaochen
force-pushed
the
closehandle
branch
from
20a0ac3
to
257674e
Compare
|
@andrewkroh I have rebased on master, but still failed with test cases in auditbeat and metricbeat |
wenhaochen
force-pushed
the
closehandle
branch
from
257674e
to
1840e0b
Compare
|
I have tried twice， passed eventually. |
|
jenkins, test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi!
signalEvent not be closed, handle leak might happen when calling Open()func a lot,
it seems not hard to recurrent such issue,
and as discuss on https://discuss.elastic.co/t/signalevent-not-be-closed/157966
signalEvent actually not work as same function in microsoft docs,
so I just add "defer" here to free the handle, which works in my test env
I'm confused that is it necessary to add any test cases or comments for the Fix, since it's sample ...
thanks !