From fdcfd3f2d6011f06dc81fa84591633851ee1e7b3 Mon Sep 17 00:00:00 2001 From: Sebastien Guilloux Date: Tue, 1 Oct 2019 15:01:46 +0200 Subject: [PATCH] Disable metrics following changes in controller-runtime (#1830) Controller-runtime metrics are now enabled by default since https://github.com/kubernetes-sigs/controller-runtime/pull/510 was merged. To disable metrics, we must explicitly set the port to "0". --- cmd/manager/main.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmd/manager/main.go b/cmd/manager/main.go index 4c310535e2..cb2ebf4bbc 100644 --- a/cmd/manager/main.go +++ b/cmd/manager/main.go @@ -222,6 +222,9 @@ func execute() { if metricsPort != 0 { log.Info("Exposing Prometheus metrics on /metrics", "port", metricsPort) opts.MetricsBindAddress = fmt.Sprintf(":%d", metricsPort) + } else { + // disable metrics + opts.MetricsBindAddress = "0" } mgr, err := ctrl.NewManager(cfg, opts)