Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import k8s.io/kubernetes/pkg/controller/volume/events #1765

Open
anyasabo opened this issue Sep 20, 2019 · 1 comment
Open

Import k8s.io/kubernetes/pkg/controller/volume/events #1765

anyasabo opened this issue Sep 20, 2019 · 1 comment

Comments

@anyasabo
Copy link
Contributor

As part of #1723, I removed the k8s.io/kubernetes/pkg/controller/volume/events import where we were depending on the VolumeDelete constant defined there, but now I just copied it in. Per Jordan's comment here:
golang/go#32776 (comment)

k8s.io/kubernetes is not primarily intended to be consumed as a module.

But I did not see that constant defined anywhere else, but maybe I was missing it. It would be better if we could work out the imports rather than copy and pasting the constant value.

@racevedoo
Copy link
Contributor

Hi @anyasabo, maybe copying is done by some other projects as well. I found a reference on https://godoc.org/github.com/kubernetes-incubator/external-storage/local-volume/provisioner/pkg/common saying exactly what you described here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants