Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch leader election to use Leases #4150

Closed
charith-elastic opened this issue Jan 26, 2021 · 1 comment · Fixed by #6717
Closed

Switch leader election to use Leases #4150

charith-elastic opened this issue Jan 26, 2021 · 1 comment · Fixed by #6717
Assignees
@barkbay
Labels
>enhancement Enhancement of existing functionality >refactoring v2.8.0

Comments

@charith-elastic
Copy link
Contributor

Since Kubernetes 1.14 a new leader election method based on the coordination.k8s.io API is available and it is the default method in controller-runtime since 0.7.0. We can switch to this new default once support for Kubernetes 1.13 is dropped from the operator.

kubernetes-sigs/controller-runtime#1144
@charith-elastic charith-elastic added >enhancement Enhancement of existing functionality >refactoring labels Jan 26, 2021
@charith-elastic charith-elastic mentioned this issue Jan 26, 2021
Merged
@naemono naemono added the v2.6.0 label Oct 3, 2022
@naemono
Copy link
Contributor

naemono commented Oct 3, 2022

In #5662 we moved to configmapleases as a temporary/interim measure. We released this in 2.3.0, and stayed on the 0.12.x branch of controller-runtime in 2.4.0. We should go ahead and moved to Leases and away from ConfigmapLeases in the next release.

@naemono naemono changed the title Switch leader election method when support for Kubernetes 1.13 is dropped Switch leader election to use Leases Oct 3, 2022
@thbkrkr thbkrkr added v2.8.0 and removed v2.6.0 labels Apr 20, 2023
@barkbay barkbay self-assigned this Apr 21, 2023
@barkbay barkbay mentioned this issue Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barkbay barkbay

Labels
>enhancement Enhancement of existing functionality >refactoring v2.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Operator leader election: use Leases only barkbay/cloud-on-k8s
4 participants
@thbkrkr @barkbay @naemono @charith-elastic