Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add support to decouple actions and exception_list from rules #3405

Open
brokensound77 opened this issue Jan 24, 2024 · 2 comments · Fixed by #3407
Open

[FR] Add support to decouple actions and exception_list from rules #3405

brokensound77 opened this issue Jan 24, 2024 · 2 comments · Fixed by #3407

Comments

@brokensound77
Copy link
Collaborator

brokensound77 commented Jan 24, 2024

related to #3298

While the repo technically supports both the actions and exceptions fields within the defined schema, it is not actually practical to populate those fields in any prebuilt rules. This is because it would create a situation where the rules would get out of sync from a versioning perspective and be in the same situation as modifying prebuilt rules.

The easiest solution would be to decouple them completely.

  • Allow users to set directories for actions and exceptions
  • The format would be TOML (or YAML), with the rule_id as the key and an array of entries respectively
  • We would need to “assemble” these at package build time, likely exposing it in the to_api_format method as well as a parameter for building packages
  • We could validate the schema of these structures just like any other rule component
  • We would likely not validate the contents of these structures (valid fields), but could consider it for the future
  • For the build time assembly, we should consider options for multi-tenancy to allow users to maintain and combine unique lists
@brokensound77 brokensound77 added the enhancement New feature or request label Jan 24, 2024
@brokensound77 brokensound77 self-assigned this Jan 24, 2024
@botelastic
Copy link

botelastic bot commented Mar 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale 60 days of inactivity label Mar 24, 2024
@Mikaayenson Mikaayenson added Area: DED Team: TRADE and removed stale 60 days of inactivity labels Mar 25, 2024
@brokensound77
Copy link
Collaborator Author

Most of this was completed in #3407 - however, since it remains in a feature branch during testing, we can leave the issue open until merged to main (or deemed as not viable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants