Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Kibana commit needs to update NOTICE.txt #53

Closed
rw-access opened this issue Jul 13, 2020 · 1 comment
Closed

[Bug] Kibana commit needs to update NOTICE.txt #53

rw-access opened this issue Jul 13, 2020 · 1 comment
Assignees
Labels
bug Something isn't working cli command line tooling

Comments

@rw-access
Copy link
Contributor

rw-access commented Jul 13, 2020

Describe the bug
Pre-commit hook not working and NOTICE.txt not updated.
I think we need to run a few yarn commands. We could also add a toggle to suppress this behavior, so we can skip this, because yarn isn't always set up.

Context: elastic/kibana#71332 (comment) from @spong

@rw-access @brokensound77 -- needed to run node scripts/notice from kibana root to regenerate the NOTICE.txt. I missed this as part of #32 as I was thinking it happened during the build, but looks like it needs to be done manually after updating any notice.ts (similar to i18n behavior). I'll defer to you for where this command fits in with your existing rules workflow, but would it be fine to add as part of the generation of this PR?

To Reproduce
See https://github.com/elastic/kibana/pull/71332/commits

Expected behavior
NOTICE.txt populated correctly

Screenshots
N/A

@rw-access rw-access added the bug Something isn't working label Jul 13, 2020
@rw-access rw-access added the cli command line tooling label Jul 13, 2020
@rw-access rw-access removed the v7.10.0 label Oct 7, 2020
@brokensound77
Copy link
Contributor

Can this be closed @rw-access?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli command line tooling
Projects
None yet
Development

No branches or pull requests

3 participants