Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes not resolved in abbreviated titles #760

Closed
lcawl opened this issue Mar 28, 2019 · 5 comments
Closed

Attributes not resolved in abbreviated titles #760

lcawl opened this issue Mar 28, 2019 · 5 comments

Comments

@lcawl
Copy link
Contributor

lcawl commented Mar 28, 2019

This problem was found while testing #756 and #649

image

The source file for this occurrence is https://github.com/elastic/stack-docs/blob/master/docs/en/stack/watcher/troubleshooting.asciidoc

++++
<titleabbrev>{watcher}</titleabbrev>
++++

A simple solution might be to just remove all these abbreviated titles.

@nik9000
Copy link
Member

nik9000 commented Mar 28, 2019

I think the asciidoctor approved fix is to add

[subs=attributes]

above it. If this is pretty rare I think we should probably just do that all of the places we use this.

@lcawl
Copy link
Contributor Author

lcawl commented Mar 29, 2019

That solves the problem in the Asciidoctor output, but it generates the following error in the non-Asciidoctor build:

ERROR ... illegal style name: subs=attributes

@nik9000
Copy link
Member

nik9000 commented Mar 29, 2019

How do you feel about [subs="attributes"]?

@lcawl
Copy link
Contributor Author

lcawl commented Mar 29, 2019

Good catch, that seems to work for both. Thanks!

@debadair
Copy link
Contributor

Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants