Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Commit

Permalink
Merge branch '7.x' into mergify/bp/7.x/pr-1136
Browse files Browse the repository at this point in the history
* 7.x:
  chore: abstract image pulling (#1137) (#1138)
  Pull fresh docker images before suite (#1123) (#1140)
  • Loading branch information
mdelapenya committed May 6, 2021
2 parents df70e88 + 961ddff commit a2ee311
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 3 deletions.
1 change: 1 addition & 0 deletions e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ The following environment variables affect how the tests are run in both the CI
>"ELASTIC_APM_ACTIVE" only affects Helm and Metricbeat test suites.
- `ELASTIC_APM_ENVIRONMENT`: Set this environment variable to `ci` to send APM data to Elastic Cloud. Otherwise, the framework will spin up local APM Server and Kibana instances. For the CI, it will read credentials from Vault. Default value: `local`.
- `SKIP_PULL`: Set this environment variable to prevent the test suite to pull Docker images for all components. Default: `false`
- `SKIP_SCENARIOS`: Set this environment variable to `false` if it's needed to include the scenarios annotated as `@skip` in the current test execution. Default value: `true`.
- `BEATS_LOCAL_PATH`: Set this environment variable to the base path to your local clone of Beats if it's needed to use the binary snapshots produced by your local build instead of the official releases. The snapshots will be fetched from the `${BEATS_LOCAL_PATH}/${THE_BEAT}/build/distributions` local directory. This variable is intended to be used by Beats developers, when testing locally the artifacts generated its own build. Default: empty.
- `BEATS_USE_CI_SNAPSHOTS`: Set this environment variable to `true` if it's needed to use the binary snapshots produced by Beats CI instead of the official releases. The snapshots will be downloaded from a bucket in Google Cloud Storage. This variable is used by the Beats repository, when testing the artifacts generated by the packaging job. Default: `false`.
Expand Down
17 changes: 17 additions & 0 deletions e2e/_suites/fleet/ingest_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"github.com/elastic/e2e-testing/cli/config"
"github.com/elastic/e2e-testing/internal/common"
"github.com/elastic/e2e-testing/internal/compose"
"github.com/elastic/e2e-testing/internal/docker"
"github.com/elastic/e2e-testing/internal/elasticsearch"
"github.com/elastic/e2e-testing/internal/installer"
"github.com/elastic/e2e-testing/internal/kibana"
Expand Down Expand Up @@ -121,6 +122,22 @@ func InitializeIngestManagerTestSuite(ctx *godog.TestSuiteContext) {
"stackVersion": common.StackVersion,
}

if !shell.GetEnvBool("SKIP_PULL") {
images := []string{
"docker.elastic.co/beats/elastic-agent:" + common.AgentVersion,
"docker.elastic.co/beats/elastic-agent-ubi8:" + common.AgentVersion,
"docker.elastic.co/elasticsearch/elasticsearch:" + common.StackVersion,
"docker.elastic.co/kibana/kibana:" + common.KibanaVersion,
"docker.elastic.co/observability-ci/elastic-agent:" + common.AgentVersion,
"docker.elastic.co/observability-ci/elastic-agent-ubi8:" + common.AgentVersion,
"docker.elastic.co/observability-ci/elasticsearch:" + common.StackVersion,
"docker.elastic.co/observability-ci/elasticsearch-ubi8:" + common.StackVersion,
"docker.elastic.co/observability-ci/kibana:" + common.KibanaVersion,
"docker.elastic.co/observability-ci/kibana-ubi8:" + common.KibanaVersion,
}
docker.PullImages(images)
}

common.ProfileEnv["kibanaDockerNamespace"] = "kibana"
if strings.HasPrefix(common.KibanaVersion, "pr") || utils.IsCommit(common.KibanaVersion) {
// because it comes from a PR
Expand Down
23 changes: 20 additions & 3 deletions internal/docker/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,8 @@ import (
"compress/gzip"
"context"
"fmt"
<<<<<<< HEAD
=======
"io"
"io/ioutil"
>>>>>>> f39aba58... feat: use Docker copy to transfer binaries to containers (#1136)
"os"
"path/filepath"
"strings"
Expand Down Expand Up @@ -539,3 +536,23 @@ func getDockerClient() *client.Client {

return instance
}

// PullImages pulls images
func PullImages(images []string) error {
c := getDockerClient()
ctx := context.Background()

log.WithField("images", images).Info("Pulling Docker images...")

for _, image := range images {
r, err := c.ImagePull(ctx, image, types.ImagePullOptions{})
if err != nil {
return err
}
_, err = io.Copy(os.Stdout, r)
if err != nil {
return err
}
}
return nil
}

0 comments on commit a2ee311

Please sign in to comment.