Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

ci: beats PR testing seems to pull in incorrect docker images during test #1323

Closed
1 of 3 tasks
adam-stokes opened this issue Jul 14, 2021 · 7 comments
Closed
1 of 3 tasks
Assignees
Labels
area:ci Anything related to the CI priority:high Product teams are waiting on features to make progress on their roadmap size:S less than 1 day Team:Fleet Label for the Fleet team triaged Triaged issues will end up in Backlog column in Robots GH Project

Comments

@adam-stokes
Copy link
Contributor

adam-stokes commented Jul 14, 2021

We had a recent failure on a beats PR: elastic/beats#26749, however when we investigated further it was determined that the actual code that was altered (basically some output being printed to screen) was not being seen. This led us to look into the test logs to verify that the code submitted in the PR was not the actual code being tested.

Next steps:

  • Determine if the gcp bucket contains a built image for that particular PR
  • Verify that the contents within that image match the code that was submitted in the PR
  • Verify that e2e-testing references the correct image when executing the test suite
@adam-stokes adam-stokes added priority:high Product teams are waiting on features to make progress on their roadmap size:S less than 1 day Team:Fleet Label for the Fleet team triaged Triaged issues will end up in Backlog column in Robots GH Project area:ci Anything related to the CI labels Jul 14, 2021
@adam-stokes
Copy link
Contributor Author

@mdelapenya I will need your help with this when you get back to verify this particular workflow

@mdelapenya
Copy link
Contributor

We manually triggered a build for the elastic/beats#26749 PR: https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-mbp/detail/master/1147/pipeline/191/

This build has been launched with GITHUB_CHECK_SHA1=208b8bc7af27e07f6a45b4439814688f0c8f0b95 and BEATS_USE_CI_SNAPSHOTS=true, so that the tests are fetching the binaries for that hash from the GCP bucket.

It's possible to reproduce it locally with:

TAGS="fleet_mode_agent" \
   GITHUB_CHECK_SHA1=208b8bc7af27e07f6a45b4439814688f0c8f0b95 \
   BEATS_USE_CI_SNAPSHOTS=true \
   TIMEOUT_FACTOR=5 \
   LOG_LEVEL=TRACE \
   DEVELOPER_MODE=true \
   ELASTIC_APM_ACTIVE=false \
make -C e2e/_suites/fleet functional-test

@cachedout
Copy link
Contributor

@mdelapenya or @adam-stokes Could you please update the status here? I would like to know whether or not #1336 resolved this issue and if not, specifically which work remains to resolve this. Thanks!

@adam-stokes
Copy link
Contributor Author

@cachedout This issue still needs to be addressed, reading over #1405 makes me wonder if the problem started after we included the automated beats version bump. Still investigating this week

@cachedout
Copy link
Contributor

@adam-stokes Sounds good. Please provide another status by the end of this work-week (Aug 5) if a resolution hasn't been found before then. Thanks!

@mdelapenya
Copy link
Contributor

I think elastic/apm-pipeline-library#1227 fixed it, but let's monitor current builds for Beats PRs since that PR was merged

@mdelapenya
Copy link
Contributor

I'm going to close this one, as it seems the images are now correct. Let's reopen it if we see it again. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:ci Anything related to the CI priority:high Product teams are waiting on features to make progress on their roadmap size:S less than 1 day Team:Fleet Label for the Fleet team triaged Triaged issues will end up in Backlog column in Robots GH Project
Projects
None yet
Development

No branches or pull requests

3 participants