Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2219: remove the less documented domain field #2120

Merged
merged 2 commits into from
Dec 1, 2022
Merged

fixes #2219: remove the less documented domain field #2120

merged 2 commits into from
Dec 1, 2022

Conversation

janstarke
Copy link
Contributor

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process?
  • If submitting code/script changes, have you verified all tests pass locally using make test?
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes?
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • Have you added an entry to the CHANGELOG.next.md?

@janstarke janstarke requested a review from a team as a code owner November 30, 2022 08:44
@cla-checker-service
Copy link

cla-checker-service bot commented Nov 30, 2022

💚 CLA has been signed

@ebeahan
Copy link
Member

ebeahan commented Nov 30, 2022

@janstarke thanks for filing the issue in #2119 and submitting the fix!

Would you please sign the Elastic CLA using the email address you used for committing this fix?

@janstarke
Copy link
Contributor Author

I already did. Do I need to reopen a pull request after signing the agreement?

Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janstarke Thanks! I see the CLA check is now ✅

I'm going to add an entry to the CHANGELOG.next, both otherwise LGTM.

@ebeahan ebeahan merged commit 47a4cde into elastic:main Dec 1, 2022
@janstarke janstarke deleted the bug/2119-unambigious-domain-field branch December 2, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants