Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote process.env_vars to GA #2315

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Jan 11, 2024

Promote process.env_vars to GA. This field has been stabilized and in use for some time now, so it should be promoted to GA status.

  • Have you signed the contributor license agreement?  ✅
  • Have you followed the contributor guidelines? ✅
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? N/A
  • If submitting code/script changes, have you verified all tests pass locally using make test? ✅
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? ✅
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. ✅
  • Have you added an entry to the CHANGELOG.next.md? ✅

The process.env_vars field has been stabalized and in use for some time now,
so it should be promoted to GA status.
@mjwolf mjwolf requested a review from a team as a code owner January 11, 2024 19:30
Copy link

Documentation changes preview: https://ecs_2315.docs-preview.app.elstc.co/diff

Copy link

@nick-alayil nick-alayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mjwolf mjwolf merged commit 375a4dd into elastic:main Jan 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants