Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

[Meta][Feature] Implement end to end acknowledgement #9

Closed
6 of 11 tasks
Tracked by #15
cmacknz opened this issue Mar 16, 2022 · 2 comments
Closed
6 of 11 tasks
Tracked by #15

[Meta][Feature] Implement end to end acknowledgement #9

cmacknz opened this issue Mar 16, 2022 · 2 comments
Assignees
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v8.4.0

Comments

@cmacknz
Copy link
Member

cmacknz commented Mar 16, 2022

This is a feature meta issue to support end to end acknowledgement in the shipper. Inputs must be able to be notified when their data has successfully been written to the target output to avoid data loss. End to end acknowledgement is only necessary when using the memory queue. Data published to the disk queue will be acknowledged immediately as it cannot be lost once persisted.

The delivery guarantees section of the shipper proposal describes the high level implementation of end to end acknowledgement in the shipper system. The Event Protocol section includes a preliminary definition of the acknowledgement streaming RPC that can be taken as a starting point.

The feature is considered complete when:

  • A test exists to prove that data published to the shipper is asynchronously acknowledged when:
    • Data is successfully written to the output system using any retry policy.
    • Data fails to write and then succeeds when using the infinite or max retry policies.
    • Data fails to write and then is dropped when using a max retry policy.
  • A test exists to prove that end to end acknowledgement behaves correctly when the shipper is restarted during publishing. Specifically, acknowledgement or queue identifiers are not reused between restarts of the process to avoid acknowledgement collisions.

The assignee of this issue is expected to create the development plan with all child issues for this feature. The following set of tasks should be included in the initial issues at a minimum:

@cmacknz
Copy link
Member Author

cmacknz commented May 30, 2022

Before implementing this we should decide if we really need to support this, or if we can just mandate use of the disk queue in cases where E2E is desired.

@cmacknz
Copy link
Member Author

cmacknz commented Feb 28, 2023

Closing, the remaining test tasks are now tracked in #264

@cmacknz cmacknz closed this as completed Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v8.4.0
Projects
None yet
Development

No branches or pull requests

3 participants