Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging around Fleet connection errors #1154

Closed
joshdover opened this issue Sep 12, 2022 · 2 comments · Fixed by #1477
Closed

Improve logging around Fleet connection errors #1154

joshdover opened this issue Sep 12, 2022 · 2 comments · Fixed by #1477
Assignees
Labels
8.6-candidate Team:Elastic-Agent Label for the Agent team

Comments

@joshdover
Copy link
Contributor

joshdover commented Sep 12, 2022

Whenever we fail to connect or disconnect before getting a response from Fleet on any API endpoint we should:

  • Include more detail about the connection
    • How long was the connection open
    • When there's a DNS failure, log the DNS transaction
  • Include more detail about how Agent is going to handle the failure
    • Is the agent going to retry, and if so, how long from now?

We should also consider making these logs less scary to users since they are expected to happen from time to time. I propose that we move the current logging from warn to info with language to explain it's intermittent and only log at the warn level if we've encountered the same issue 3 out of the last 5 attempts. Today it will skip the first instance and log only if it happens twice in a row

@cmacknz
Copy link
Member

cmacknz commented Sep 21, 2022

@AndersonQ I am going to pick this one up if you haven't started it (I think you were on PTO when it was assigned).

@cmacknz cmacknz assigned cmacknz and unassigned AndersonQ Sep 21, 2022
@jlind23
Copy link
Contributor

jlind23 commented Oct 10, 2022

@cmacknz Any update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6-candidate Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants