Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move agent upgrade tests to official snapshots to a scheduled job #3475

Closed
pchila opened this issue Sep 26, 2023 · 5 comments
Closed

Move agent upgrade tests to official snapshots to a scheduled job #3475

pchila opened this issue Sep 26, 2023 · 5 comments
Labels
Team:Elastic-Agent Label for the Agent team Testing

Comments

@pchila
Copy link
Member

pchila commented Sep 26, 2023

Currently the elastic agent upgrade tests use a mixture of locally built and official snapshot as target versions for upgrade tests.
Such upgrade tests are run for PR and commits on branches.

The purpose of this PR is to move the tests that use official snapshot in a separate, scheduled job instead of running for each commit.

@pchila pchila added Team:Elastic-Agent Label for the Agent team Testing labels Sep 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@blakerouse
Copy link
Contributor

Actually with my PR #3477 I don't believe we need to do this. I original thought that it made sense to move these, but the more I thought about it as long as the does does one or the other then its a valid test and should remain.

  • Start version is the build version, upgrading to another version
  • Start version is another version, upgrading to build version

@pierrehilbert
Copy link
Contributor

@pchila any objection on @blakerouse point of view or could we close this one?

@pchila
Copy link
Member Author

pchila commented Nov 10, 2023

The idea behind this issue was run the upgrade where we upgrade from a released version to a SNAPSHOT version that has been built by a nightly job (mostly to cover Fleet managed upgrades).
If those usecases are covered by #3477 as @blakerouse says I have no problem closing this issue

@pierrehilbert
Copy link
Contributor

Closing for now and will reopen if necessary

@pierrehilbert pierrehilbert closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team Testing
Projects
None yet
Development

No branches or pull requests

4 participants