Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Feature] Secondary fallback for package signature verification (#3453) (#3497) #3508

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

pchila
Copy link
Member

@pchila pchila commented Oct 4, 2023

This reverts commit 635b147.

What does this PR do?

Reverts commit that broke the ability of the agent to communicate locally with fleet-server when bootstrapping it.

Why is it important?

Restores Elastic cloud deployment functionality

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Oct 4, 2023
@pchila pchila requested a review from a team as a code owner October 4, 2023 11:49
@pchila pchila self-assigned this Oct 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pchila pchila linked an issue Oct 4, 2023 that may be closed by this pull request
3 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-04T11:50:13.022+0000

  • Duration: 28 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 6277
Skipped 55
Total 6332

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.765% (80/81) 👍
Files 67.832% (194/286) 👎 -0.35
Classes 66.48% (357/537) 👍
Methods 53.112% (1118/2105) 👎 -0.117
Lines 38.563% (12702/32938) 👎 -0.102
Conditionals 100.0% (0/0) 💚

@cmacknz
Copy link
Member

cmacknz commented Oct 4, 2023

Force merging, we need this fix for the tests to pass.

@cmacknz cmacknz merged commit 72dc8ce into elastic:8.10 Oct 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken/Flaky integration tests on main
4 participants