Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/panic with composable renderer #823

Merged
merged 5 commits into from
Aug 10, 2022

Commits on Aug 1, 2022

  1. Fix a panic with wg passed to the composable object

    In the code to retrieve the variables from the configuration files we
    need to pass a execution callback, this callback will be called in a
    goroutine. This callback can be executed multiple time until the
    composable renderer is stopped. There were a problem in the code that
    made the callback called multiple time and it made the waitgroup
    internal counter to do to a negative values.
    
    This commit change the behavior, it start the composable renderer give
    it a callback when the callback receives the variables it will stop the
    composable's Run method using the context.
    
    This ensure that the callback will be called a single time and that the
    variables are correctly retrieved.
    
    Fixes: elastic#806
    ph committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    18a0b8c View commit details
    Browse the repository at this point in the history
  2. adding changelog

    ph committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    1583d1c View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Configuration menu
    Copy the full SHA
    fb7b626 View commit details
    Browse the repository at this point in the history
  2. typo

    ph committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    9a0aab1 View commit details
    Browse the repository at this point in the history
  3. fix reviews

    ph committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    c1a0f18 View commit details
    Browse the repository at this point in the history