Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend sizing does not account for scrollbar width #1011

Closed
nickofthyme opened this issue Feb 3, 2021 · 5 comments · Fixed by #1019, #1115 or #1458
Closed

Legend sizing does not account for scrollbar width #1011

nickofthyme opened this issue Feb 3, 2021 · 5 comments · Fixed by #1019, #1115 or #1458
Assignees
Labels
bug Something isn't working :legend Legend related issue released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Feb 3, 2021

Describe the bug
The Right or Left legend positions do not account for the browser scrollbar. Particularly, with short legend names.

Only on Chrome and Safari, not FireFox.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://elastic.github.io/elastic-charts/?path=/story/small-multiples-alpha--grid-lines&knob-Show Legend=true
  2. Toggle the legend with the provided knob
  3. Notice the legend item labels are truncated due to the scroll bar.

Expected behavior
Somehow account for the scrollbar width when legend values exceed the height of the legend container.

Screenshots
Screen Recording 2021-02-03 at 09 35 AM

When the legend container is set to overflow-x: hidden the issue goes away

image

Kibana Cross Issues
elastic/kibana#94596

@nickofthyme nickofthyme added bug Something isn't working :legend Legend related issue labels Feb 3, 2021
@nickofthyme nickofthyme self-assigned this Feb 10, 2021
@markov00
Copy link
Member

🎉 This issue has been resolved in version 24.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Feb 15, 2021
@nickofthyme nickofthyme reopened this Apr 12, 2021
@nickofthyme
Copy link
Collaborator Author

Still an issue, see elastic/kibana#94596

@nickofthyme
Copy link
Collaborator Author

🎉 This issue has been resolved in version 28.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme reopened this Oct 29, 2021
@nickofthyme
Copy link
Collaborator Author

This issue was found to still remain in Windows browsers.

@nickofthyme nickofthyme linked a pull request Nov 2, 2021 that will close this issue
6 tasks
@nickofthyme
Copy link
Collaborator Author

This issue was caused by kibana overriding legend :focus styles with Amsterdam theme which confilcts with us not using the Amsterdam theme. Closing in favor of #1461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :legend Legend related issue released Issue released publicly
Projects
None yet
2 participants