You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Back when we migrated to playwright we adopted the old viewport size from puppeteer. This is fine, however we also added styles for .echVisualTesting particularly a padding of 200px for testing tooltip popper placement.
Since we have this padding in place, any story that goes outside of the confines of the #story-root risks being clipped in the vrt screenshot.
I would suggest a better way of handling this, ideally we can simply maximize the viewport size and limit the screenshot to the .echChart that defaults to a certain size. But in this case anything that goes beyond the #story-root would still be captured correctly.
The key to this working without changing a ton of screenshots is to force the .echChart element size to be consistent no matter the size of the browser window.
The text was updated successfully, but these errors were encountered:
Back when we migrated to playwright we adopted the old viewport size from puppeteer. This is fine, however we also added styles for
.echVisualTesting
particularly apadding
of200px
for testing tooltip popper placement.elastic-charts/storybook/style.scss
Lines 100 to 116 in 1bd36c7
Since we have this
padding
in place, any story that goes outside of the confines of the#story-root
risks being clipped in the vrt screenshot.I would suggest a better way of handling this, ideally we can simply maximize the viewport size and limit the screenshot to the
.echChart
that defaults to a certain size. But in this case anything that goes beyond the#story-root
would still be captured correctly.The key to this working without changing a ton of screenshots is to force the
.echChart
element size to be consistent no matter the size of the browser window.The text was updated successfully, but these errors were encountered: