Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force stacking on single histogram series #2223

Closed
3 tasks done
nickofthyme opened this issue Nov 1, 2023 · 0 comments · Fixed by #2225
Closed
3 tasks done

Do not force stacking on single histogram series #2223

nickofthyme opened this issue Nov 1, 2023 · 0 comments · Fixed by #2225
Assignees
Labels
bug Something isn't working :data Data/series/scales related issue :xy Bar/Line/Area chart related

Comments

@nickofthyme
Copy link
Collaborator

Describe the issue

Whenever a user creates a bar series and enables the enableHistogramMode flag, the series is treated as stacked.

This unexpectedly disabled the domain fitting due to the filling of dataseries values for stacked series.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/empty-pond-lfn4t2
  2. Toggle enableHistogramMode option
  3. Notice how the domain fit is applied in each case

Expected behaviour
Domain fit should not be impacted by whether the enableHistogramMode flag is enabled or not.

Version (please complete the following information):

  • Elastic Charts: v21.0.0

Additional context

This issues was introduced in #751 by treating any bar series with enableHistogramMode set to true as stacked. This was done to prevent clustered bar charts in a histogram.

The solution here would be to only force the stacking behavior for histogram bar charts when there is more than one bar series.

Kibana Cross Issues

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • Every related Kibana issue is listed under Kibana Cross Issues list and the kibana cross issue tag is applied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :data Data/series/scales related issue :xy Bar/Line/Area chart related
Projects
None yet
1 participant