fix: (Legend values) percentage formatter should be distict from tick formatter #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
changed the title
mbondyra
force-pushed
the
fix_legend_stats_issues
branch
2 times, most recently
from
440bb1b to
e405c71
Compare
mbondyra
changed the title
mbondyra
force-pushed
the
fix_legend_stats_issues
branch
4 times, most recently
from
245db6f to
2b3dd1e
Compare
mbondyra
force-pushed
the
fix_legend_stats_issues
branch
from
2b3dd1e to
b02a4dd
Compare
mbondyra
force-pushed
the
fix_legend_stats_issues
branch
from
75f9b69 to
d83cf67
Compare
|
buildkite update screenshots |
mbondyra
commented
Jun 27, 2024
...-tabular-data/should-correctly-display-current-and-last-value-median-values-chrome-linux.png
Outdated
Show resolved
Hide resolved
mbondyra
commented
Jun 27, 2024
...ries/legend-tabular-data/should-correctly-display-long-copy-dataset-dataset-chrome-linux.png
Outdated
Show resolved
Hide resolved
mbondyra
commented
Jun 27, 2024
...s/legend-stories/legend-tabular-data/should-correctly-display-median-values-chrome-linux.png
Outdated
Show resolved
Hide resolved
nickofthyme
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Change look good!
It kinda feels to me that we are in need of a some type of separate legendValueFormatter instead of just relying on the tickFormat for everything. This way we could let the user handle the percent and null cases directly.
Similar to how we have a labelFormat option just to format the axis label values apart from the tooltip values, see demo here.
No changes required, just commenting for future discussion.
packages/charts/src/chart_types/xy_chart/state/utils/get_legend_values.ts
Show resolved
Hide resolved
packages/charts/src/chart_types/xy_chart/state/utils/get_legend_values.ts
Show resolved
Hide resolved
nickofthyme
reviewed
Jun 28, 2024
...es/legend-tabular-data/should-correctly-display-null-values-dataset-dataset-chrome-linux.png
Outdated
Show resolved
Hide resolved
|
I am gonna go ahead and merge it so I can start working on upgrading it in Kibana |
nickofthyme
pushed a commit
that referenced
this pull request
Jul 1, 2024
## [66.0.5](v66.0.4...v66.0.5) (2024-07-01) ### Bug Fixes * (Legend values) percentage formatter should be distict from tick formatter ([#2474](#2474)) ([b5bd998](b5bd998))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a few small issues for legend values:
MBas a suffix, unnecessary scroll appears. That's because we calculate the width of each cell approximately and we underestimated. I corrected it by changing the width to 8.5 for each letter.I changed one of the tests to make sure we test at least one stacked chart.