feat(xy): render sorting #2524
Merged
feat(xy): render sorting #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
enhancement
|
buildkite update screenshots |
markov00
reviewed
Sep 23, 2024
...ages/charts/src/chart_types/xy_chart/state/selectors/get_tooltip_values_highlighted_geoms.ts
Outdated
Show resolved
Hide resolved
packages/charts/src/chart_types/xy_chart/state/utils/utils.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
|
buildkite update screenshots |
markov00
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Looks good to me, thanks.
With this change, and my applied changes, we need to specify this as a breaking change. In the mixed stacked/nonstacked environment, the color assigned is inverted: first, the stacked then the non-stacked, the same way you read the chart left-right.
Please mark this as breaking change when merging.
nickofthyme
pushed a commit
that referenced
this pull request
Oct 8, 2024
# [68.0.0](v67.0.1...v68.0.0) (2024-10-08) ### Features * **xy:** render sorting ([#2524](#2524)) ([c514571](c514571)) ### BREAKING CHANGES * **xy:** The way mixed stacked/nonstacked series are colored now is different from the previous behaviour. Now we color them not by their insert index but by the way we display them in the rendering: from the left to right, bottom top, stacked, nonstacked. This align correctly also the legend colors by default. This does **not** affect colors assigned via a `SeriesColorAccessor`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds render sorting for xy charts. See demo story here.
Details
Render order
Settings.renderSortfunctionLegend items order
Settings.legendSort, original array is based on render order.Tooltip items order
Tooltip.sort, original array is based on render order.Breaking changes
The way mixed stacked/nonstacked series are colored now is different from the previous behaviour. Now we color them not by their insert index but by the way we display them in the rendering: from the left to right, bottom top, stacked, nonstacked. This align correctly also the legend colors by default. This does not affect colors assigned via a
SeriesColorAccessor.Issues
Related to elastic/kibana#191988
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)packages/charts/src/index.ts