Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theming] Migrate away from eui sass files or sass altogether #2551

Open
1 of 3 tasks
nickofthyme opened this issue Oct 16, 2024 · 0 comments
Open
1 of 3 tasks

[Theming] Migrate away from eui sass files or sass altogether #2551

nickofthyme opened this issue Oct 16, 2024 · 0 comments
Labels

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Oct 16, 2024

With eui now fully migrated to emotion, they will soon be deprecating their sass files. Charts currently relies on several sass files from eui (see _eui_imports.scss) to match basic styles from eui. These include variables, functions and mixins.

Action items

  • Identify what things (i.e. mixins, variable, etc.) we are consuming from eui.
  • Understand eui's timeline for removal of scss files from their output.
    • EUI says no hard deadline just yet, feels like it's about 6 months out or so.
  • Decide on the action(s) to be taken below.

Possibile solutions

  • Duplicate eui sass file functionality in charts.
  • Convert eui js styles to scss for chart consumption.
  • Use custom chart styles to get close.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant