Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metric] Improve title/subtitle/extra visibility breakpoint based on fit font size #2554

Open
markov00 opened this issue Oct 22, 2024 · 0 comments
Labels
enhancement New feature or request :metric Related to Metric chart

Comments

@markov00
Copy link
Member

Based on this discussion #2548 (comment)
We probably could improve the elementVisibility breakpoits based on the new default calculations.
Currently we do the following:

  • first we compute the heightBasedFontSizes and the element visibility for title/subtitle/extra/value based only on height (with getMetricTextPartDimensions)
  • then we compute the fit fontsize for the value (with getFitValueFontSize)
  • and then we update the calculated value font size based on the desired configuration (fit, default/snap)

We can probably change this to compute the element visibility after that to increase the visibility of more text as possible

@markov00 markov00 added :metric Related to Metric chart enhancement New feature or request labels Oct 22, 2024
@markov00 markov00 changed the title [Metric] Improve title/subtitle/extra visibility breakpoint based on fit fot size [Metric] Improve title/subtitle/extra visibility breakpoint based on fit font size Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :metric Related to Metric chart
Projects
None yet
Development

No branches or pull requests

1 participant