Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(heatmap): respect margins and paddings #2577

Merged
merged 34 commits into from
Jan 28, 2025
Merged

fix(heatmap): respect margins and paddings #2577

merged 34 commits into from
Jan 28, 2025

Conversation

mariairiartef
Copy link
Contributor

@mariairiartef mariairiartef commented Dec 16, 2024 •
edited
Loading

Summary

The margins and paddings are applied correctly for heatmap chart configuration theme.

Screenshot 2025-01-17 at 12 27 35 Screenshot 2025-01-17 at 12 27 47

Small multiples

Screenshot 2025-01-17 at 12 28 52 Screenshot 2025-01-17 at 12 29 02

Brush mask and area

Screen.Recording.2025-01-20.at.16.11.46.mov

Details

Add debug option so when is active elements such as margins, paddings, chart dimensions and chart container dimensions are visible.

Issues

fix #2216

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)

@mariairiartef mariairiartef added bug Something isn't working :heatmap Heatmap/Swimlane chart related issue labels Dec 16, 2024
@mariairiartef mariairiartef self-assigned this Dec 16, 2024
@markov00
Copy link
Member

buildkite test this

@mariairiartef mariairiartef mentioned this pull request Jan 20, 2025
Open
@mariairiartef mariairiartef marked this pull request as ready for review January 21, 2025 09:04
@markov00 markov00 self-requested a review January 22, 2025 13:47
@nickofthyme
Copy link
Collaborator

Still reviewing with finish tomorrow.

@nickofthyme
Copy link
Collaborator

Sorry got tied up today. I promise tomorrow first thing!!

mbondyra
mbondyra approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Chrome and it works great! Thank you for tackling it!

nickofthyme
nickofthyme approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay 🙃

These changes are really great! You nailed the dimensional placement logic, I couldn't find any issues.

I just left a few nits/comment, but nothing major.

packages/charts/src/chart_types/heatmap/renderer/canvas/canvas_renderers.ts Outdated Show resolved Hide resolved
packages/charts/src/chart_types/heatmap/renderer/canvas/dimensions.ts Outdated Show resolved Hide resolved
packages/charts/src/chart_types/heatmap/renderer/canvas/theme.ts Outdated Show resolved Hide resolved
packages/charts/src/chart_types/heatmap/renderer/canvas/dimensions.ts Outdated Show resolved Hide resolved
packages/charts/src/renderers/canvas/primitives/text.ts Outdated Show resolved Hide resolved
packages/charts/src/chart_types/heatmap/renderer/canvas/dimensions.ts Outdated Show resolved Hide resolved
@mariairiartef
Copy link
Contributor Author

buildkite update screenshots

@mariairiartef
Copy link
Contributor Author

buildkite update screenshots

@mariairiartef mariairiartef merged commit c24566d into elastic:main Jan 28, 2025
14 checks passed
nickofthyme pushed a commit that referenced this pull request Jan 29, 2025
@semantic-release-bot
chore(release): 69.1.0 [skip ci]
bfb0d28 
# [69.1.0](v69.0.0...v69.1.0) (2025-01-29)

### Bug Fixes

* **deps:** update dependency json-schema-to-typescript to v15.0.4 ([#2522](#2522)) ([2d4b650](2d4b650))
* **heatmap:** respect margins and paddings ([#2577](#2577)) ([c24566d](c24566d))
* **themes:** reintroduce Amsterdam colors ([#2604](#2604)) ([8c9913d](8c9913d))

### Features

* **heatmap:** add rotation in heatmap debug state ([#2594](#2594)) ([9047bd2](9047bd2))
@mariairiartef mariairiartef mentioned this pull request Jan 30, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

@mbondyra mbondyra mbondyra approved these changes

@markov00 markov00 markov00 approved these changes

Assignees

@mariairiartef mariairiartef

Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue :theme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heatmap does not respect theme.chartMargins
4 participants
@mariairiartef @markov00 @nickofthyme @mbondyra