Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): align xy axis style to borealis #2584

Merged

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Jan 15, 2025

Summary

This PR aligns the axis borealis colors for Cartesian charts.

Only ~970 VRT changes 😅, sorry about that but this changes all the axis colors.

Note for reviewers:
Is easy to just take a look at the changes in the first commit and just ignore the VRT changes.

@markov00 markov00 added enhancement New feature or request :axis Axis related issue :styling Styling related issue :theme labels Jan 15, 2025
@markov00
Copy link
Member Author

buildkite update screenshots

@markov00 markov00 marked this pull request as ready for review January 17, 2025 17:15
@markov00 markov00 requested a review from nickofthyme January 17, 2025 17:15
Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 😱 😱

@markov00 markov00 merged commit 9486374 into elastic:main Jan 17, 2025
14 checks passed
@markov00 markov00 deleted the 2025_01_15-align_xy_axis_style_to_borealis branch January 17, 2025 18:13
nickofthyme pushed a commit that referenced this pull request Jan 28, 2025
# [69.0.0](v68.1.0...v69.0.0) (2025-01-28)

### Bug Fixes

* **deps:** update dependency @elastic/eui to v99 ([#2567](#2567)) ([f397987](f397987))
* **style:** align xy axis style to borealis ([#2584](#2584)) ([9486374](9486374))

### Styles

* **theme:** cleanup remaining theme changes ([#2602](#2602)) ([beb4cf1](beb4cf1)), closes [#2601](#2601)

### BREAKING CHANGES

* **theme:** the light and dark themes follow the EUI Borealis theme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:axis Axis related issue enhancement New feature or request :styling Styling related issue :theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants