-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to toggle annotation on/off #299
Comments
Might also consider some sort of grouping logic. |
@AlonaNadler this feature seems a bit out of scope of the chart library itself. We are also removing from the chart itself the legend button toggle #268 in favour of let the consumer of the chart implement it's own toggle |
Let's crosslink this other enhancement: #555 |
@vinaychandrasekhar the main issue, seems to me, is requesting a toggle for all annotations. Is this your expectation too? Or is your request to toggle each annotation individually? If so what is your expected behavior? If we toggle the from the annotation marker/icon, is the line just toggled or the marker/icon too? |
@nickofthyme thank you for the questions. cc @katrin-freihofner and @hbharding for their thoughts and input.
Ideally, I'd imagine each type of annotation having a toggle facility - so, for example, a user might want to toggle the alerts off but might want to retain some other annotation "type" on the charts. Ticket 555 offers a way to control it in that way.
Toggling each annotation individually would be too onerous on the user, and could get confusing (for example: if they walk away from the screen after toggling one individual alert but not others, and coming back to that screen later). |
Ah got it, so the annotations grouping as a whole is only toggleable via the legend. I think #555 will cover you use case but I added a requirement to enable toggling the annotations on that issue. I'll keep this open for now and close later if applicable. |
Is your feature request related to a problem? Please describe.
Annotations are very helpful when narrowed down into a specific period of time or filtered on a specific value. When looking at a longer period of time without any filter apply annotations can sometimes overload the chart
It will be helpful to have a switch to turn on/off the annotations from the specific chart when in dashboard/Visualize
The text was updated successfully, but these errors were encountered: