Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack offsets #715

Closed
nickofthyme opened this issue Jun 16, 2020 · 1 comment · Fixed by #751
Closed

Stack offsets #715

nickofthyme opened this issue Jun 16, 2020 · 1 comment · Fixed by #751
Assignees
Labels
:data Data/series/scales related issue enhancement New feature or request released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Enable stack offsets for wiggle and silhouette.

Silhouette
Shifts the baseline down such that the center of the streamgraph is always at zero.

Wiggle
Shifts the baseline so as to minimize the weighted wiggle of layers. This offset is recommended for streamgraphs in conjunction with the inside-out order. See Stacked Graphs—Geometry & Aesthetics by Bryon & Wattenberg for more information.

Additional context
Required for vislib feature parity

@nickofthyme nickofthyme added enhancement New feature or request :data Data/series/scales related issue labels Jun 16, 2020
@markov00 markov00 self-assigned this Jul 13, 2020
markov00 added a commit to markov00/elastic-charts that referenced this issue Jul 23, 2020
the `stackMode` was introduced to apply percentage, wiggle and silhouette offset for stacking
charts.

BREAKING CHANGE: `stackAsPercentage` prop was replaced by `stackMode` that accept one `StackModes`.

fix elastic#715
markov00 added a commit that referenced this issue Jul 29, 2020
This commit adds the wiggle and silhouette stacks mode as available in vislib that allow the creation of streamgraph. It is also to fix fit functions for stacked charts. The commit also add the following fixes:
- fit functions are now available also on stacked charts
- the legend extra value is now displayed, on-demand, only on charts with a continuous x-axis
- Adjusts slightly the way fitted data is represented in the case of null values and no fit option specified. It renders an empty area in this case
- for zero-based charts (bar and area charts) the fit option doesn't have any effects
- djusts the clipped ranges for ordinal charts, where the lines where wrongly clipped due to a missing translate call when rendering

BREAKING CHANGE: the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`.

fix #766
fix #715
close #450
markov00 pushed a commit that referenced this issue Aug 10, 2020
# [21.0.0](v20.0.2...v21.0.0) (2020-08-10)

### Bug Fixes

* update dep vulnerabilities, minimist and kind-of ([#763](#763)) ([4455281](4455281))
* **legend:** fix color anchor, add action context, fix action padding ([#774](#774)) ([4590a22](4590a22))
* **tooltip:** placement with left/top legends and single bars ([#771](#771)) ([e576b26](e576b26)), closes [#769](#769) [#770](#770)

### Features

* streamgraph and fit functions on stacked charts ([#751](#751)) ([268fcc0](268fcc0)), closes [#766](#766) [#715](#715) [#450](#450)

### BREAKING CHANGES

* the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`.
@markov00
Copy link
Member

🎉 This issue has been resolved in version 21.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 10, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
# [21.0.0](elastic/elastic-charts@v20.0.2...v21.0.0) (2020-08-10)

### Bug Fixes

* update dep vulnerabilities, minimist and kind-of ([opensearch-project#763](elastic/elastic-charts#763)) ([843554f](elastic/elastic-charts@843554f))
* **legend:** fix color anchor, add action context, fix action padding ([opensearch-project#774](elastic/elastic-charts#774)) ([262f8d2](elastic/elastic-charts@262f8d2))
* **tooltip:** placement with left/top legends and single bars ([opensearch-project#771](elastic/elastic-charts#771)) ([75533b1](elastic/elastic-charts@75533b1)), closes [opensearch-project#769](elastic/elastic-charts#769) [opensearch-project#770](elastic/elastic-charts#770)

### Features

* streamgraph and fit functions on stacked charts ([opensearch-project#751](elastic/elastic-charts#751)) ([6f6a8cb](elastic/elastic-charts@6f6a8cb)), closes [opensearch-project#766](elastic/elastic-charts#766) [opensearch-project#715](elastic/elastic-charts#715) [opensearch-project#450](elastic/elastic-charts#450)

### BREAKING CHANGES

* the first parameter of `PointStyleAccessor` and `BarStyleAccessor` callbacks is changed from `RawDataSeriesDatum` to `DataSeriesDatum`. `stackAsPercentage` prop is replaced by `stackMode` that accept one `StackMode`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:data Data/series/scales related issue enhancement New feature or request released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants