-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotations #81
Comments
As a note, also the brush tool can be managed as a an annotation on the chart. We can split the events handling from the rendering part. |
Just wanted to get some feedback about how the user will configure annotations. I propose that we add a new spec Here's a rough proposal of what the annotation configs might look like:
And then when defining the chart, you would add:
|
@emmacunningham I think you are on the right track. I like the idea of helpers for data, specially because I maybe want to have an annotation on a specific series in a clustered bar chart and I know the X value, but not the position of the series on the cluster. I see few other possibilities on the data structure:
we can also move the const lineAnnotation = {
type: 'x',
position: 0,
marker: 'star',
datum: { title: 'title', desc: 'desc'}
};
...
<Annotations
lines={[lineAnnotation]}
lineStyles={{
color: 'black',
strokeWidth: 2,
}}
hoverComponent={({title, desc}) => <div>{title} <br/>{desc}</div>}
/> |
Closing this keeping only the remaining #106 |
Is your feature request related to a problem? Please describe.
We need to display annotations on charts like the current time marker, partial-data areas or other general annotations.
Describe the solution you'd like
Add the possibility to include vertical or horizontal lines or rectangles on the chart, specifying the base x or y value where the line will lie.
This can be split into 3 different tasks:
Describe alternatives you've considered
n/a
Additional context
n/a
Kibana Cross Issues
Add any Kibana related issues/feature requests here.
Checklist
Kibana Cross Issues
listkibana cross issue
tag is associated to the issue if any kibana cross issue is presentThe text was updated successfully, but these errors were encountered: