Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.7 deprecation in 6.x version #951

Closed
edariedl opened this issue Aug 7, 2020 · 2 comments
Closed

Ruby 2.7 deprecation in 6.x version #951

edariedl opened this issue Aug 7, 2020 · 2 comments

Comments

@edariedl
Copy link

edariedl commented Aug 7, 2020

Hey, would it be possible to fix ruby 2.7 deprecation also in 6.x version of the gem?

https://github.com/elastic/elasticsearch-rails/blob/6.x/elasticsearch-model/lib/elasticsearch/model/adapters/active_record.rb#L88

Line should look like this.

scope.find_in_batches(**options) do |batch|

It is already fixed in 7.x version, unfortunately not in 6.x.

Thanks!

@picandocodigo
Copy link
Member

Hi @edariedl,
Thanks for reporting this. I just published version 6.1.1 which includes this fix!
Check it out and let me know if there's any other issues.

Cheers!

@edariedl
Copy link
Author

Awesome! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants