From 928fe3fb662eda27113b0ca955dcd0bcdc2d97d9 Mon Sep 17 00:00:00 2001
From: Armin Braun <me@obrown.io>
Date: Thu, 13 Sep 2018 12:40:41 +0200
Subject: [PATCH] CORE: Disable Setting Type Validation (#33660)

* Reverts setting type validation introduced in #33503
---
 .../main/java/org/elasticsearch/common/settings/Setting.java    | 2 +-
 .../java/org/elasticsearch/common/settings/SettingTests.java    | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/server/src/main/java/org/elasticsearch/common/settings/Setting.java b/server/src/main/java/org/elasticsearch/common/settings/Setting.java
index 5244cdd726d05..23984e58749f7 100644
--- a/server/src/main/java/org/elasticsearch/common/settings/Setting.java
+++ b/server/src/main/java/org/elasticsearch/common/settings/Setting.java
@@ -458,7 +458,7 @@ public final String getRaw(final Settings settings) {
      * @return the raw string representation of the setting value
      */
     String innerGetRaw(final Settings settings) {
-        return settings.get(getKey(), defaultValue.apply(settings), isListSetting());
+        return settings.get(getKey(), defaultValue.apply(settings));
     }
 
     /** Logs a deprecation warning if the setting is deprecated and used. */
diff --git a/server/src/test/java/org/elasticsearch/common/settings/SettingTests.java b/server/src/test/java/org/elasticsearch/common/settings/SettingTests.java
index 30cfee81ddd40..99fde0855f94a 100644
--- a/server/src/test/java/org/elasticsearch/common/settings/SettingTests.java
+++ b/server/src/test/java/org/elasticsearch/common/settings/SettingTests.java
@@ -180,6 +180,7 @@ public void testSimpleUpdate() {
         }
     }
 
+    @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/33135")
     public void testValidateStringSetting() {
         Settings settings = Settings.builder().putList("foo.bar", Arrays.asList("bla-a", "bla-b")).build();
         Setting<String> stringSetting = Setting.simpleString("foo.bar", Property.NodeScope);