ESQL: Skip lookup csv tests on release builds #110166
Merged
+97
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOOKUP isn't supported in release builds yet and it'll fail with a helpful error message if you try it there. But some of the csv-spec tests didn't realize that. Lots did, but these particular ones didn't. Close elastic#109170
nik9000
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Jun 26, 2024
| } else { | ||
| assumeFalse( | ||
| "lookup is not supported in non-snapshot releases", | ||
| testCase.requiredCapabilities.contains(EsqlCapabilities.Cap.LOOKUP_V3.capabilityName()) |
There was a problem hiding this comment.
Suggestion: We could extend this skip to all caps that are snapshot-only.
|
Thanks Nik! I already wondered why the non snapshot case seems to work; turns out it didn't in all cases. |
|
run elasticsearch-ci/release-tests |
|
@elasticsearchmachine update branch |
|
There's a few more release build failures. Working. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOOKUP isn't supported in release builds yet and it'll fail with a helpful error message if you try it there. But some of the csv-spec tests didn't realize that. Lots did, but these particular ones didn't.
Closes #109170
Closes #110302