Rest Tests for Painless do not respect the API spec

[honzakral]

In (0) you can see a test that uses lang instead of id to get around the bug fixed by #25736

This test, however, should be failing since it doesn't specify both lang and id which are marked as required in the API spec. This suggests that either the test is not being run as it should or that the test runner doesn't check for all required attributes.

0 - https://github.com/elastic/elasticsearch/blob/5.x/modules/lang-painless/src/test/resources/rest-api-spec/test/painless/16_update2.yaml#L7-L9

[javanna]

The test is run, but the java yaml test runner doesn't check whether required parameters are specified or not. That unfortunately allows for writing tests that may not work when run from other runners. Marking adoptme.

[olcbean]

Hey @javanna, can I give this one a try if you are not working on it? my thinking is to enforce not only the params but also the required parts.

[javanna]

go for it @olcbean , thanks!

[olcbean]

@honzakral the test is correct but unfortunately the rest-api-spec for put_script in 5.6 contains a minor mistake : id should have been "required" : false (see #26923 for more details; the same applies to delete_script and get_script).

#27035 makes sure that if a url parameter is specified as required but it is not provided, then the test fails.

@honzakral @javanna is there anything else that needs to be done for this issue?
(The mentioned issues are fixed for 6.0+)

[javanna]

I think we are good @olcbean , closing! Thanks a lot for your contributions!