-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink API should inherit (most of) original index's settings #28347
Comments
++ sounds good to me |
To note, there probably needs to be a mechanism for settings to opt-out of being copied. For example, we would not want to copy cross-cluster replication settings as these would point to the pre-shrunken index. |
The process for removal is a little different than I envisaged (sorry for not mentioning this earlier, I had not thought about the removal process until @jasontedor opened #30321 to implement it. I had thought that we would:
The worry I have with the approach listed above is that it puts the hard break in 7.0 since there is no way of not copying settings so to me it seems that its the same as just removing the parameter in 7.0? |
I've updated the description to reflect latest comments above ^ as well as an offline discussion had with @jasontedor and @colings86. Originally, the description stated that we will deprecate the setting in |
closed in the effort around introducing a notion of copy-settings #30255 |
Currently, The shrunken target index inherits close to none of the original index's properties.
Since #25035 and #25380, other things are ignored.
At the moment, shrink relies on index templates, and just copies over mappings, and index.analysis.* and index.similarities.* from the original index.
It feels like it would make more sense for the shrunken index to be as close to a copy of the original
as possible. This would mean inheriting all the settings and mappings. Although, it should not inherit the aliases.
One way of solving this is to change the behavior and keep the new behavior behind a backwards-compatible query-param (maybe called
copy_existing
) that defaults tofalse
.this flag would be:
copy_existing
setting explicitly configured totrue
. Configuring it tofalse
is not allowed.true
, still disallowed to befalse
, and deprecatedThe text was updated successfully, but these errors were encountered: