-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Consider using search_after instead of scroll in datafeeds #29781
Comments
One more consideration with switching to Sorting on time and #39187 (comment) contains an idea for a fully deterministic datafeed sort order. However, the comment below shows that we decided to step back from it in case it also caused performance problems. |
Switching to |
The work being done in #61062 to implement #26472 solves this. Once #61062 is merged we can switch from scroll to |
We need to be very careful about implementing this. #68833 was only merged into 7.12, and it is likely to be required by any change from scroll to point-in-time |
Original comment by @droberts195:
@dimitris-athanasiou tested scroll VS search_after on a @dolaru's qa 6-node cluster (though those instances are quite small, t2.medium)
However, search_after does have some benefits for ML, like not being at risk of broken scrolls.
The text was updated successfully, but these errors were encountered: