Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable S3 repo temporary/EC2/ECS credentials tests for third-party tests #32318

Closed
vladimirdolzhenko opened this issue Jul 24, 2018 · 2 comments
Closed

Enable S3 repo temporary/EC2/ECS credentials tests for third-party tests #32318

vladimirdolzhenko opened this issue Jul 24, 2018 · 2 comments
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs help wanted adoptme >test Issues or PRs that are addressing/adding tests

Comments

@vladimirdolzhenko
Copy link
Contributor

temporary/EC2/ECS credentials tests for repository-s3 are disabled for third-party tests

See: #31919 and #32315

It is required to extend configuration of CI build to support env variables

  • amazon_s3_access_key_temporary, amazon_s3_secret_key_temporary, amazon_s3_session_token_temporary, amazon_s3_bucket_temporary, amazon_s3_base_path_temporary
  • amazon_s3_bucket_ec2, amazon_s3_base_path_ec2
  • amazon_s3_bucket_ecs, amazon_s3_base_path_ecs
@vladimirdolzhenko vladimirdolzhenko added >test Issues or PRs that are addressing/adding tests help wanted adoptme :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Jul 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@vladimirdolzhenko vladimirdolzhenko mentioned this issue Jul 24, 2018
Merged
@original-brownbear
Copy link
Member

I'm closing this one as it doesn't really get us anything to run the temporary/EC2/ECS test suits against real S3. They are just subsets of the currently running permanent credentials suit at this point anyway.
We can maybe look into drying the tests up here to make that fact more obvious but running redundant tests against real S3 is unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs help wanted adoptme >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vladimirdolzhenko @original-brownbear @elasticmachine