Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] MovAvgIT#testBadModelParams needs clarification #34046

Closed
cbuescher opened this issue Sep 25, 2018 · 2 comments
Closed

[Test] MovAvgIT#testBadModelParams needs clarification #34046

cbuescher opened this issue Sep 25, 2018 · 2 comments
Assignees
Labels
:Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI

Comments

@cbuescher
Copy link
Member

Currently the "testBadModelParams" method does seem to pass regardless of whether bad
model parameters are used or not. My guess is that its supposed to be testing that an exception is
thrown if you provide invalid model parameters. From a conversation with @colings86 we think that
the padding parameter passed in ensure the alpha and beta values are invalid, but that seems to be
trappy because if the randomness selects simple or linear models the padding isn’t used and the model
will be valid. I will @AwaitsFix the test in the course of #31876
where I stumbled into it, but create this issue for further investigation.

@cbuescher cbuescher added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations v7.0.0 labels Sep 25, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@cbuescher
Copy link
Member Author

Another MovAvgIT test (testHoltWintersNotEnoughData) fails for a similar reason:

./gradlew :server:integTest -Dtests.seed=CE15410BFF4D8B8A -Dtests.class=org.elasticsearch.search.aggregations.pipeline.moving.avg.MovAvgIT -Dtests.method="testHoltWintersNotEnoughData" -Dtests.security.manager=true -Dtests.locale=fi -Dtests.timezone=JST -Dcompiler.java=10 -Druntime.java=8
FAILURE 0.39s | MovAvgIT.testHoltWintersNotEnoughData <<< FAILURES!
   > Throwable #1: junit.framework.AssertionFailedError: Expected exception SearchPhaseExecutionException but no exception was thrown
   >    at __randomizedtesting.SeedInfo.seed([CE15410BFF4D8B8A:A5C013FEF4A98B75]:0)
   >    at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2687)
   >    at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2672)
   >    at org.elasticsearch.search.aggregations.pipeline.moving.avg.MovAvgIT.testHoltWintersNotEnoughData(MovAvgIT.java:856)
   >    at java.lang.Thread.run(Thread.java:748)

I think this needs a similar treatment like the issue mentioned above. The test it muted now as well, would be good to clean this up in one go.

@jasontedor jasontedor added v8.0.0 and removed v7.0.0 labels Feb 6, 2019
@polyfractal polyfractal added >test-failure Triaged test failures from CI and removed >test Issues or PRs that are addressing/adding tests v8.0.0 labels Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

4 participants