Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: move SQL request parameters from http url params to JSON body payload #35992

Closed
astefan opened this issue Nov 28, 2018 · 3 comments
Closed

SQL: move SQL request parameters from http url params to JSON body payload #35992

astefan opened this issue Nov 28, 2018 · 3 comments
Assignees
@astefan
Labels
:Analytics/SQL SQL querying >bug v6.6.0 v7.0.0-beta1

Comments

@astefan
Copy link
Contributor

astefan commented Nov 28, 2018

At the moment, an sql request gets the parameters as http request parameters (mode for example). Apart from the fact that it should be possible to get them inside the JSON payload (which doesn't currently work), we should completely switch to having these parameters in the JSON body only.
We should, also, be strict with the body content and only allow valid elements.
@astefan astefan self-assigned this Nov 28, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@costin
Copy link
Member

costin commented Nov 28, 2018

/cc @bpintea

@astefan astefan mentioned this issue Dec 3, 2018
Merged
@astefan
Copy link
Contributor Author

astefan commented Dec 11, 2018

Master (7.0.0): eead8a1
6.x (6.6.0): ea19d8f

@astefan astefan mentioned this issue Dec 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astefan astefan

Labels
:Analytics/SQL SQL querying >bug v6.6.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@costin @colings86 @astefan @elasticmachine