Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Failure persisting datafeed timing stats leaves datafeed in limbo #49032

Closed
droberts195 opened this issue Nov 13, 2019 · 2 comments
Closed
Labels
>bug :ml Machine learning

Comments

@droberts195
Copy link
Contributor

Since 7.4.0 when a datafeed is stopped it tries to persist datafeed timing stats. However, this is done in the finally block in DatafeedManager.stop(), and if it fails for some reason then the datafeed is not fully stopped. It remains permanently in the stopping state, and due to #48931 there is currently no way to stop a datafeed that is stuck in the stopping state.

Failure to persist datafeed timing stats for some reason should be logged as a warning but should not prevent more critical datafeed shutdown actions from being attempted.

@droberts195 droberts195 added >bug :ml Machine learning labels Nov 13, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek
Copy link
Contributor

przemekwitek commented Nov 19, 2019

This issue is now fixed in 7.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml Machine learning
Projects
None yet
Development

No branches or pull requests

3 participants