Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine date and date_nanos into a field family #67722

Open
astefan opened this issue Jan 19, 2021 · 6 comments
Open

Combine date and date_nanos into a field family #67722

astefan opened this issue Jan 19, 2021 · 6 comments
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@astefan
Copy link
Contributor

astefan commented Jan 19, 2021

As part of #53175, we can consider merging together date and date_nanos data types into a generic date data type. _field_caps API would only return date whenever date or date_nanos exists in indices mappings.

Relates to #38562.
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Jan 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@astefan astefan added the :Search Foundations/Mapping Index mappings, including merging and defining field types label Jan 19, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jan 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@astefan astefan removed :Analytics/EQL EQL querying :Analytics/SQL SQL querying labels Jan 19, 2021
@elasticmachine elasticmachine removed the Team:QL (Deprecated) Meta label for query languages team label Jan 19, 2021
@astefan astefan changed the title QL: merge together date and date_nanos as a single data type Merge together date and date_nanos as a single data type Jan 19, 2021
@astefan
Copy link
Contributor Author

astefan commented Jan 19, 2021

Depends on #67727.

@matriv
Copy link
Contributor

matriv commented Jan 20, 2021 •
edited
Loading

Relates also with: #67666

@jtibshirani jtibshirani changed the title Merge together date and date_nanos as a single data type Combine date and date_nanos into a field family Jan 27, 2021
matriv added a commit to matriv/elasticsearch that referenced this issue Jan 29, 2021
@matriv
QL: Eliminate internal type DATETIME_NANOS
b0963f2 
Moving towards grouping of data types in the field caps API
the internal data type `DATETIME_NANOS` introduced for `date_nanos`
supports is eliminated.

Relates: elastic#67722
Follows: elastic#67666
@matriv matriv mentioned this issue Jan 29, 2021
Merged
matriv added a commit that referenced this issue Feb 10, 2021
@matriv
QL: Eliminate internal type DATETIME_NANOS (#68220)
45677a3 
Moving towards grouping of data types in the field caps API
the internal data type `DATETIME_NANOS` introduced for `date_nanos`
support is eliminated.

Relates: #67722
Follows: #67666
@matriv matriv mentioned this issue Feb 10, 2021
Merged
matriv added a commit that referenced this issue Feb 10, 2021
@matriv
QL: Eliminate internal type DATETIME_NANOS (#68220) (#68850)
b5c4667 
Moving towards grouping of data types in the field caps API
the internal data type `DATETIME_NANOS` introduced for `date_nanos`
support is eliminated.

Relates: #67722
Follows: #67666

(cherry picked from commit 45677a3)
@jpountz
Copy link
Contributor

jpountz commented Aug 26, 2022

I just stumbled on this Kibana issue, where some apps in Kibana do not recognize the date_nanos type. Giving date_nanos the date type family would automatically fix it.

One thing that is unclear to me: do date fields generally support being queried with nanosecond resolution? If not, then this could be an issue as it would mean that clients have to know the resolution of date fields at query time?

@javanna javanna added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jpountz @javanna @astefan @matriv @jtibshirani @elasticmachine @elasticsearchmachine