Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine float, scaled_float and half_float into same field family #67723

Closed
astefan opened this issue Jan 19, 2021 · 6 comments
Closed

Combine float, scaled_float and half_float into same field family #67723

astefan opened this issue Jan 19, 2021 · 6 comments
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@astefan
Copy link
Contributor

astefan commented Jan 19, 2021

As part of #53175, we can consider merging together float, half_float and scaled_float data types into a generic float data type. _field_caps API would only return float whenever float, half_float or scaled_float exists in indices mappings.
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Jan 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@astefan astefan changed the title QL: merge together float, scaled_float and half_float as a single data type Merge together float, scaled_float and half_float as a single data type Jan 19, 2021
@astefan astefan added :Search Foundations/Mapping Index mappings, including merging and defining field types and removed :Analytics/EQL EQL querying :Analytics/SQL SQL querying labels Jan 19, 2021
@elasticmachine elasticmachine added Team:Search Meta label for search team and removed Team:QL (Deprecated) Meta label for query languages team labels Jan 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@astefan
Copy link
Contributor Author

astefan commented Jan 19, 2021

Depends on #67727.

@jtibshirani jtibshirani changed the title Merge together float, scaled_float and half_float as a single data type Combine float, scaled_float and half_float into same field family Jan 27, 2021
@jtibshirani
Copy link
Contributor

This sounds like a great follow-up to #53175! @astefan hope it's okay with you, I updated the title to refer to 'field families' to avoid confusion. We usually say 'data type' to mean a concrete field type in the mappings.

@jtibshirani
Copy link
Contributor

We decided to look into this seriously, and plan to catch up with other teams to get their opinions.

@JVerwolf JVerwolf mentioned this issue Jun 6, 2023
Closed
@javanna
Copy link
Member

javanna commented Jun 9, 2023

Based on more recent discussions, this change has implications and brings little gain, hence we are not going to make it.

@javanna javanna closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2023
@javanna javanna added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create float type family JVerwolf/elasticsearch
4 participants
@javanna @astefan @jtibshirani @elasticmachine