Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrations tests should be regularly run with assertions disabled #69067

Open
mark-vieira opened this issue Feb 16, 2021 · 1 comment
Open
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@mark-vieira
Copy link
Contributor

As discussed here we lack coverage for detecting if we are implicitly relying on side effects in assertions due to the fact that we don't run external cluster tests w/ assertions disabled. We have found issues in the past in production related specifically to side effects in assertion statements.

We should add a periodic build for catching things like this which simply runs our external cluster tests against a cluster configured as it would be in production, w/o -ea.

@mark-vieira mark-vieira added the :Delivery/Build Build or test infrastructure label Feb 16, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Feb 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

No branches or pull requests

2 participants