Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][ML] PyTorchModelIT testEvaluateWithMinimalTimeout failure #81091

Closed
davidkyle opened this issue Nov 29, 2021 · 2 comments · Fixed by #81094
Closed

[CI][ML] PyTorchModelIT testEvaluateWithMinimalTimeout failure #81091

davidkyle opened this issue Nov 29, 2021 · 2 comments · Fixed by #81094
Labels
:ml Machine learning Team:ML Meta label for the ML team >test-failure Triaged test failures from CI

Comments

@davidkyle
Copy link
Member

Build scan:
https://gradle-enterprise.elastic.co/s/irafccgouilyk
https://gradle-enterprise.elastic.co/s/vgysxwentnox6

Repro line:

./gradlew ':x-pack:plugin:ml:qa:native-multi-node-tests:javaRestTest' --tests "org.elasticsearch.xpack.ml.integration.PyTorchModelIT.testEvaluateWithMinimalTimeout" \
  -Dtests.seed=82882C0276D19551 \
  -Dtests.locale=fr-CH \
  -Dtests.timezone=Europe/Dublin \
  -Druntime.java=17

Reproduces locally?:
No

Applicable branches:
8.1, 8.0

Failure history:

Failure excerpt:

junit.framework.AssertionFailedError: Expected exception ResponseException but no exception was thrown
	at __randomizedtesting.SeedInfo.seed([82882C0276D19551:65FE53F0D91AAB91]:0)
	at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2874)
	at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2860)
	at org.elasticsearch.xpack.ml.integration.PyTorchModelIT.testEvaluateWithMinimalTimeout(PyTorchModelIT.java:203)
@davidkyle davidkyle added >test-failure Triaged test failures from CI :ml Machine learning labels Nov 29, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Nov 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@davidkyle
Copy link
Member Author

The test is meant to show the inference timeout parameter is respected by setting the value to zero but there is a race between the timeout code and inference in some cases inference occurs normally.

In this case the logs show the request was processed in 4ms.

[2021-11-22T22:34:51,148][DEBUG][o.e.x.m.i.d.DeploymentManager] [javaRestTest-1] Inference Request {"request_id":"9","tokens":[[3,4]],"arg_1":[[1,1]],"arg_2":[[0,0]],"arg_3":[[0,1]]}
[2021-11-22T22:34:51,152][DEBUG][o.e.x.m.i.d.DeploymentManager] [javaRestTest-1] [test_evaluate_timeout] retrieved result for request [9]
[2021-11-22T22:34:51,152][DEBUG][o.e.x.m.i.d.DeploymentManager] [javaRestTest-1] [test_evaluate_timeout] processed result for request [9]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning Team:ML Meta label for the ML team >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants