Remove 8.11 node version inference code #116019
Conversation
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@edsavage am I correct in thinking that 8.18+ nodes will always have ML and Transform config version attributes on them? |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
Yes, that's correct. |
There was a problem hiding this comment.
LGTM.
One question: this PR assumes that v9 nodes will never talk to "old" v8 nodes, but just with v8.last.
My understanding is that this is what we want to do, but do we have a barrier in place? Is it enforced somewhere e.g. in JoinRequest?
(it's just curiosity on my side)
| if (transformConfigVerStr != null) { | ||
| return fromString(transformConfigVerStr); | ||
| } | ||
| return fromId(node.getPre811VersionId().orElseThrow(() -> new IllegalStateException("getting legacy version id not possible"))); |
There was a problem hiding this comment.
Nit: this is the last usage of getPre811VersionId, can we remove it? Or do you want to do that in another PR?
There was a problem hiding this comment.
I'm removing it in #115434
|
Yes, v9 will only be able to talk to 8.18. This is enforced by |
|
@elasticmachine rerun elasticsearch-ci/part-2 |
Remove the mapping from version to transport version needed to communicate with pre-8.11 nodes. This is needed to remove Version from DiscoveryNode entirely (see #115434)