From 23638cb3ac4de5331d76db098a03024a5be591dd Mon Sep 17 00:00:00 2001 From: David Turner Date: Fri, 29 Sep 2017 10:20:26 +0100 Subject: [PATCH 1/2] Change delayed_timeout to be a positiveTimeSetting --- .../java/org/elasticsearch/cluster/routing/UnassignedInfo.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/java/org/elasticsearch/cluster/routing/UnassignedInfo.java b/core/src/main/java/org/elasticsearch/cluster/routing/UnassignedInfo.java index cba9acbbbb9fa..a543f4c3d3b3e 100644 --- a/core/src/main/java/org/elasticsearch/cluster/routing/UnassignedInfo.java +++ b/core/src/main/java/org/elasticsearch/cluster/routing/UnassignedInfo.java @@ -50,7 +50,7 @@ public final class UnassignedInfo implements ToXContentFragment, Writeable { public static final FormatDateTimeFormatter DATE_TIME_FORMATTER = Joda.forPattern("dateOptionalTime"); public static final Setting INDEX_DELAYED_NODE_LEFT_TIMEOUT_SETTING = - Setting.timeSetting("index.unassigned.node_left.delayed_timeout", TimeValue.timeValueMinutes(1), Property.Dynamic, + Setting.positiveTimeSetting("index.unassigned.node_left.delayed_timeout", TimeValue.timeValueMinutes(1), Property.Dynamic, Property.IndexScope); /** * Reason why the shard is in unassigned state. From 8daa669678c333390f50e9ea8f534db9243adcf4 Mon Sep 17 00:00:00 2001 From: David Turner Date: Fri, 29 Sep 2017 10:46:09 +0100 Subject: [PATCH 2/2] Add note that this is a breaking change --- docs/reference/migration/migrate_7_0/indices.asciidoc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/reference/migration/migrate_7_0/indices.asciidoc b/docs/reference/migration/migrate_7_0/indices.asciidoc index eeecacc06fc06..2decc6c9cdd02 100644 --- a/docs/reference/migration/migrate_7_0/indices.asciidoc +++ b/docs/reference/migration/migrate_7_0/indices.asciidoc @@ -5,3 +5,8 @@ Due to cross-cluster search using `:` to separate a cluster and index name, index names may no longer contain `:`. + +==== `index.unassigned.node_left.delayed_timeout` may no longer be negative + +Negative values were interpreted as zero in earlier versions but are no +longer accepted.