From c5ab1b318394a504329c2632b6cfca5782ee2c71 Mon Sep 17 00:00:00 2001 From: Jason Tedor Date: Wed, 21 Mar 2018 09:34:30 -0400 Subject: [PATCH 1/2] Add migration note on thread pool API changes A previous change modified the output of the thread pool info contained in the nodes info API. This commit adds a note to the migration docs for this change. --- docs/reference/migration/migrate_7_0/api.asciidoc | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/docs/reference/migration/migrate_7_0/api.asciidoc b/docs/reference/migration/migrate_7_0/api.asciidoc index 5fd425857c32f..4fc367c32cadc 100644 --- a/docs/reference/migration/migrate_7_0/api.asciidoc +++ b/docs/reference/migration/migrate_7_0/api.asciidoc @@ -22,3 +22,18 @@ The following parameters starting with underscore have been removed: Instead of these removed parameters, use their non camel case equivalents without starting underscore, e.g. use `version_type` instead of `_version_type` or `versionType`. +==== Thread pool info + +In previous versions of Elasticsearch, the thread pool info returned in the +<> returned `min` and `max` values reflecting +the configured minimum and maximum number of threads that could be in each +thread pool. The trouble with this representation is that it does not align with +the configuration parameters used to configure thread pools. For +<>, the minimum number of threads is +configured by a parameter called `core` and the maximum number of threads is +configured by a parameter called `max`. For <>, there is only one configuration parameter along these lines and that +parameter is called `size`, reflecting the fixed number of threads in the +pool. This discrepancy between the API and the configuration parameters has been +rectified. Now, the API will report `core` and `max` for scaling thread pools, +and `size` for fixed thread pools. From 5f2c89c3e2b174369eccf1c9bb12039e9befa762 Mon Sep 17 00:00:00 2001 From: Jason Tedor Date: Thu, 5 Apr 2018 06:15:44 -0400 Subject: [PATCH 2/2] Add cat thread pool changes --- docs/reference/migration/migrate_7_0/api.asciidoc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/reference/migration/migrate_7_0/api.asciidoc b/docs/reference/migration/migrate_7_0/api.asciidoc index 4fc367c32cadc..0b5bdede0afef 100644 --- a/docs/reference/migration/migrate_7_0/api.asciidoc +++ b/docs/reference/migration/migrate_7_0/api.asciidoc @@ -37,3 +37,13 @@ parameter is called `size`, reflecting the fixed number of threads in the pool. This discrepancy between the API and the configuration parameters has been rectified. Now, the API will report `core` and `max` for scaling thread pools, and `size` for fixed thread pools. + +Similarly, in the cat thread pool API the existing `size` output has been +renamed to `pool_size` which reflects the number of threads currently in the +pool; the shortcut for this value has been changed from `s` to `psz`. The `min` +output has been renamed to `core` with a shortcut of `cr`, the shortcut for +`max` has been changed to `mx`, and the `size` output with a shortcut of `sz` +has been reused to report the configured number of threads in the pool. This +aligns the output of the API with the configuration values for thread +pools. Note that `core` and `max` will be populated for scaling thread pools, +and `size` will be populated for fixed thread pools.