From d62e83be891471d1663f9f3e6e5517751f508479 Mon Sep 17 00:00:00 2001 From: Armin Braun Date: Mon, 15 Oct 2018 09:43:25 +0200 Subject: [PATCH] MINOR: Remove Deadcode in ExpressionTermSetQuery --- .../script/expression/ExpressionScriptEngine.java | 3 +-- .../script/expression/ExpressionTermSetQueryScript.java | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/modules/lang-expression/src/main/java/org/elasticsearch/script/expression/ExpressionScriptEngine.java b/modules/lang-expression/src/main/java/org/elasticsearch/script/expression/ExpressionScriptEngine.java index 7330bd6ea5d0e..39e8c3ef6ebf1 100644 --- a/modules/lang-expression/src/main/java/org/elasticsearch/script/expression/ExpressionScriptEngine.java +++ b/modules/lang-expression/src/main/java/org/elasticsearch/script/expression/ExpressionScriptEngine.java @@ -221,8 +221,7 @@ private TermsSetQueryScript.LeafFactory newTermsSetQueryScript(Expression expr, throw convertToScriptException("link error", expr.sourceText, variable, e); } } - ReplaceableConstDoubleValueSource specialValue = null; - return new ExpressionTermSetQueryScript(expr, bindings, specialValue); + return new ExpressionTermSetQueryScript(expr, bindings); } /** diff --git a/modules/lang-expression/src/main/java/org/elasticsearch/script/expression/ExpressionTermSetQueryScript.java b/modules/lang-expression/src/main/java/org/elasticsearch/script/expression/ExpressionTermSetQueryScript.java index d2fd77713ea18..c5a2ae5b4b9af 100644 --- a/modules/lang-expression/src/main/java/org/elasticsearch/script/expression/ExpressionTermSetQueryScript.java +++ b/modules/lang-expression/src/main/java/org/elasticsearch/script/expression/ExpressionTermSetQueryScript.java @@ -38,13 +38,11 @@ class ExpressionTermSetQueryScript implements TermsSetQueryScript.LeafFactory { final Expression exprScript; final SimpleBindings bindings; final DoubleValuesSource source; - final ReplaceableConstDoubleValueSource specialValue; // _value - ExpressionTermSetQueryScript(Expression e, SimpleBindings b, ReplaceableConstDoubleValueSource v) { + ExpressionTermSetQueryScript(Expression e, SimpleBindings b) { exprScript = e; bindings = b; source = exprScript.getDoubleValuesSource(bindings); - specialValue = v; } @Override