From 0eb7be32daa82cd3e9adec5161192293c051b396 Mon Sep 17 00:00:00 2001 From: Heather McCartney Date: Thu, 17 Jan 2019 18:39:45 +0000 Subject: [PATCH 1/2] Document the need for JAVA11_HOME --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2e5f6685ecf9f..3cd6ebb7982ff 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -100,8 +100,8 @@ JDK 11 and testing on a JDK 8 runtime; to do this, set `RUNTIME_JAVA_HOME` pointing to the Java home of a JDK 8 installation. Note that this mechanism can be used to test against other JDKs as well, this is not only limited to JDK 8. -> Note: It is also required to have `JAVA8_HOME`, `JAVA9_HOME`, and -`JAVA10_HOME` are available so that the tests can pass. +> Note: It is also required to have `JAVA8_HOME`, `JAVA9_HOME`, `JAVA10_HOME` +and `JAVA11_HOME` are available so that the tests can pass. > Warning: do not use `sdkman` for Java installations which do not have proper `jrunscript` for jdk distributions. From f8f26ea35f20250cf417f354054a6ccc3e8b3a70 Mon Sep 17 00:00:00 2001 From: Ryan Ernst Date: Fri, 18 Jan 2019 11:15:47 -0800 Subject: [PATCH 2/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3cd6ebb7982ff..23ca7a299e588 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -101,7 +101,7 @@ pointing to the Java home of a JDK 8 installation. Note that this mechanism can be used to test against other JDKs as well, this is not only limited to JDK 8. > Note: It is also required to have `JAVA8_HOME`, `JAVA9_HOME`, `JAVA10_HOME` -and `JAVA11_HOME` are available so that the tests can pass. +and `JAVA11_HOME` available so that the tests can pass. > Warning: do not use `sdkman` for Java installations which do not have proper `jrunscript` for jdk distributions.