Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fixed typos (_op => op) #50301

Merged
merged 3 commits into from
Jan 8, 2020
Merged

[DOCS] Fixed typos (_op => op) #50301

merged 3 commits into from
Jan 8, 2020

Conversation

consulthys
Copy link
Contributor

The documentation mentions the ctx.op parameter here, here and here, however the respective Painless context documentation uses ctx._op instead.

According to the source code, it should be ctx.op. So this PR aims at fixing those typos in the documentation.

@consulthys consulthys changed the title Fixed documentation typos (_op => op) [DOCS] Fixed typos (_op => op) Dec 18, 2019
@jtibshirani jtibshirani added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Dec 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@jtibshirani jtibshirani added the >docs General docs changes label Dec 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me. @stu-elastic @jdconrad would one of you mind confirming?

@jrodewig
Copy link
Contributor

jrodewig commented Jan 8, 2020

@elasticmachine test this please

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this.

@jrodewig
Copy link
Contributor

jrodewig commented Jan 8, 2020

Thanks @jdconrad. Will merge and backport once the CI tests finish.

@jrodewig
Copy link
Contributor

jrodewig commented Jan 8, 2020

Backport commits

master: f8e41ed
7.x: f3ddd40
7.5: a086226
6.8: d92d7b6

@jrodewig
Copy link
Contributor

jrodewig commented Jan 8, 2020

Merged and backported to 6.8 and 7.5+.Thanks for your contribution @consulthys!

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes v6.8.7 v7.5.2 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants